Add timeout to HTTP calls

wmalgadey / PyTado

Python binding for Tado web API. Pythonize your central heating!

GNU General Public License v3.0

76 stars 41 forks source link

Add timeout to HTTP calls #18

Closed michaelarnauts closed 4 years ago

michaelarnauts commented 4 years ago

I have some strange lockups in Home Assistant recently, and this might be caused by SyncWorker starvation. The last log message I have in my logs is always a GET to Tado.

Looking at the library, it seems that there are no timeouts specified here: https://github.com/wmalgadey/PyTado/blob/master/PyTado/interface.py#L51

michaelarnauts commented 4 years ago

Also, it might be a good idea to move to requests instead of urllib.

wmalgadey commented 4 years ago

I will take a look into this this week

michaelarnauts commented 4 years ago

@wmalgadey any progress, or can I help with that?

wmalgadey commented 4 years ago

@michaelarnauts sorry for my delay! work got way too busy lately. If you have some time to spare, your help would be kindly appreciate