Closed chiefdragon closed 1 year ago
@mattthewclayton I've just realised you've submitted a similar PR to me. I've been sitting on it for months and only just got around to committing and PRing :-) We've implemented setAuto() pretty much the same, coincidentally. I've also added tests, as well as add checks to ensure it can't be used if the Tado Home doesn't support auto geofencing (i.e. doesn't have the Auto Assist skill). I guess if your PR is accepted, then mine can be applied over the top (or I can merge and resolve conflicts, then re-submit my PR), alternatively if mine is approved, I guess you'd only need to apply your timetabling fix. @wmalgadey - happy to help whichever way you'd prefer to apply them
I was being lazy just pushing the extra setTimetable fixes on the same PR I'll kill my PR and just make one for those fixes alone.
Great, thanks