wmalgadey / PyTado

Python binding for Tado web API. Pythonize your central heating!
GNU General Public License v3.0
76 stars 41 forks source link

Water tap heating not chaging mode #9

Closed bruvv closed 4 years ago

bruvv commented 5 years ago

When I use the heating it works fine when I want to do the same for the water tap it does not work.

- id: '1545245312247'
  alias: Verwarming uit
  trigger:
  - entity_id: sensor.huiskamer_tado_mode
    platform: state
    to: AWAY
  condition: []
  action:
  - entity_id: climate.huiskamer
    service: climate.set_operation_mode
    data:
      operation_mode: Off
  - entity_id:  climate.warm_water
    service: climate.set_operation_mode
    data:
      operation_mode: Off

That is what I use.

bruvv commented 5 years ago

Still an issue

neonbunny commented 5 years ago

This is a Home Assistant specific issue which should be covered as part of https://github.com/home-assistant/home-assistant/issues/22712

bartn commented 5 years ago

So, @neonbunny, this means the pyTado supports the warm_water already, but we should fix the home-assistant component?

neonbunny commented 5 years ago

Correct @bartn - I hacked together a fix for home-assistant which let me change the hot water without needing to modify pyTado. However, I've not submitted my dirty fix as the PR referenced above more cleanly covers it (and a whole lot more).

iIRC, the home-assistant tado module never called the API since it was looking for a difference in temperature values which hot water systems simply didn't have.

bartn commented 5 years ago

Hi @neonbunny , sorry to bother again, but as I am super eager to lower my energy use, I want to tackle the warm water control of Tado asap. Is there a way for me to run your hacked code as a custom component in HA?

Diondk commented 5 years ago

I would also be very interested in the hacked code, as i want to control my tado water also.

michaelarnauts commented 4 years ago

I have an open PR here https://github.com/home-assistant/home-assistant/pull/30095 that allows to control hot water without temperature control. When temperature control is possible, the component would create a climate in the past. This is changed to a water heater now.

wmalgadey commented 4 years ago

closing, because it has been merged on homeassistant and may be fixed now?