search

wmanley / git-meld

Wrapper around git and meld for comparing git trees
GNU General Public License v2.0
207 stars 36 forks source link

«"cd $(git-parse..." failed with code 512» if white spaces in root dir name #16

Closed pacoqueen closed 12 years ago

pacoqueen commented 12 years ago

If folder name contains blank spaces, git-meld fails with:

sh: 1: cd: can't cd to /home/... cd $(git rev-parse --show-toplevel) && git archive rosales ".gitignore" | tar -x -C "/tmp/git-meld.F8dhcE/..." failed with exit code 512 at .../git-meld line 27.

I think because dirname isn't escaped before "cd" to it (line 150).

safe_cmd("cd \$(git rev-parse --show-toplevel) && git archive $tree $escaped_file_list | tar -x -C \"$out_dir\"");

pacoqueen commented 12 years ago

Solution in issue 17