search

wmanley / git-meld

Wrapper around git and meld for comparing git trees
GNU General Public License v2.0
207 stars 36 forks source link

Correct white spaces in dirname issue #17

Closed pacoqueen closed 12 years ago

pacoqueen commented 12 years ago

If parent directory name contains blank spaces, git rev-parse --show-toplevel fails. Escaping command before "cd" to it solves the problem.

wmanley commented 12 years ago

Thanks for the patch, it's a good spot and it seems very sensible. Would it be possible for you to add a regression test to tests.sh for this issue? The general pattern is to do set-up and invoke git-meld in the testthat... function and check that git meld did the right thing in the testthat..._handler function.

pacoqueen commented 12 years ago

Pull request number 18 (https://github.com/wmanley/git-meld/pull/18) contains this patch and a regression test. Closing this thread.