wmanth / vscode-jar-viewer

JAR Viewer Extension for VS Code
Other
7 stars 3 forks source link

Not working in VSCode Remote Server, Dev Container, WSL #19

Open gitolicious opened 1 year ago

gitolicious commented 1 year ago

The extension does not show JAR contents when VSCode is running remotely (as in "inside a container, in WSL, or on a remote machine").

I suspect the issue somewhere around here, as the uri is showing the local filename which is not accessible/valid in a remote setting.

https://github.com/wmanth/vscode-jar-viewer/blob/349fdef70bd73db3cc09e3369df3f72ccd7d7151/src/JarEditorProvider.ts#L43

Reproduction steps:

  1. open VS Code remotely, e.g. in a Dev Container or at https://gitpod.io/#https://github.com/wmanth/vscode-jar-viewer/
  2. install extension and open jar file
    code --install-extension wmanth.jar-viewer
    touch hello.txt
    zip hello.jar hello.txt
    code hello.jar