search

wmariuss / awesome-devops

A curated list of awesome DevOps platforms, tools, practices and resources
http://awesome-devops.xyz
Creative Commons Zero v1.0 Universal
2k stars 303 forks source link

📦 Add link check action #26

Closed TechWiz-3 closed 1 year ago

TechWiz-3 commented 2 years ago

In this PR, I have added a workflow which checks links and fails if any of them are broken.

Disclaimer: this action is my own action, the repo is here

You can view the logs of the workflow on my fork here. 2 links were found to be broken.

Let me know if you'd like me to change anything, any feedback is appreciated either way :)

wmariuss commented 2 years ago

Hi,

Nice workflow. The question is can we make also If the URL is safe enought?

TechWiz-3 commented 2 years ago

Thank you 😌

What do you mean safe enough though? If the connection is not secure (i.e. no SSL certificate) the link is considered to be broken and is added to the bad links list, I could also create an option that enforces only https links too if that's what you mean 🤔

wmariuss commented 2 years ago

Yes, if it has SSL cert valid, but also, the content is safe.

TechWiz-3 commented 2 years ago

Surely it wouldn't be added if the content isn't safe?

In any case, that would be a cool feature to explore, any ideas on how that can be measure? Also, any ideas on what defines 'safe' content?

wmariuss commented 2 years ago

Ok, add SSL validation for now. and in the future is good to have content validation as well.

TechWiz-3 commented 2 years ago

SSL validation is already in place

Screen Shot 2022-08-13 at 12 19 16 am
TechWiz-3 commented 2 years ago

Also don't worry about the 429 errors in the screenshot. That screenshot was taken from an update that I'm working on which hasn't been pushed yet

TechWiz-3 commented 2 years ago

Any updates @wmariuss ?

wmariuss commented 2 years ago

Any updates @wmariuss ?

Please see the comments.