wmaurer / vscode-jumpy

Jumpy Extension for Visual Studio Code
MIT License
120 stars 31 forks source link

Decorations font and color customization #16

Closed stormherz closed 6 years ago

stormherz commented 7 years ago

Added support for font and color customization. There is a small issue with pixel-perfect rendering of the decorations (which isn't quite noticeable and won't affect functionality of the extension), but that's how vscode is currently implemented, can't really do anything about it. Should resolve #6.

capaj commented 7 years ago

@wmaurer is this PR problematic in some way? How is it not merged yet? Customizing of the font is number 1 requested feature in the issues.

wmaurer commented 7 years ago

Hi @stormherz & @capaj I'm very sorry I've been unresponsive about this. My open-source projects have taken a low priority in the last few months due to personal reasons.

Many thanks @stormherz for implementing this functionality. It looks good from a code point of view.

The only problem I see at the moment is that with decorations for words in the first column. Unfortunately it's a little cut off on the left: image My feeling is that we need to position the decorator a little bit to the right ... it's rather difficult, I'd spent quite a bit of time getting the right dimensions and position for the decorator based on the hardcoded font size, but now with it being configurable, it's even harder to get right.

stormherz commented 7 years ago

Ah, I see, I'll try to fix things up

stormherz commented 7 years ago

@wmaurer could you take a look? I've moved decorators a few pixels to the right, should do the trick for a beam cursor. That's still a hardcode tweaking, but the main issue is obviously with the decorator API itself, which is quite poor at the moment, so we must use SVG to present jump markers. If there was a way of overlaying a decorator with a custom content/htm/css =(

ghost commented 7 years ago

Would be great if this PR was integrated, the current font is really small..

seanyu4296 commented 6 years ago

Would be great to see this merged

olso commented 6 years ago

@wmaurer ❤️ pls

olso commented 6 years ago

Holy shhhh 😍😍