wmayner / pyphi

A toolbox for integrated information theory.
https://journals.plos.org/ploscompbiol/article?id=10.1371/journal.pcbi.1006343
Other
364 stars 98 forks source link

Couldn't find collections.abc #20

Closed fischerdom closed 6 years ago

fischerdom commented 6 years ago

Hey man,

I am not sure if I did something wrong on my Ubuntu-Server, but I had to add import collections.abc to the file .../pyphi/models/cuts.py.

Cheers, Dominik

wmayner commented 6 years ago

Hey Dominik!

That's strange. What Python version are you using, and what version of PyPhi? And were you doing anything in particular when the error came up, or just import pyphi?

fischerdom commented 6 years ago

Yes, sounds strange to me, too. I am using Python 3.4. i just used my common phi calculations for Markov brains.

William Mayner notifications@github.com schrieb am Mi., 6. Juni 2018, 20:35:

Hey Dominik!

That's strange. What Python version are you using, and what version of PyPhi? And were you doing anything in particular when the error came up, or just import pyphi?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wmayner/pyphi/issues/20#issuecomment-395170325, or mute the thread https://github.com/notifications/unsubscribe-auth/AFJIMVG9gxjqB6cWiBtuuKW4MqS_kdK9ks5t6CDdgaJpZM4UcCRR .

wmayner commented 6 years ago

All the tests on Travis are passing for Python 3.4, 3.5, and 3.6 so it's probably something specific to your system, though I have no guess as to why, because this shouldn't be system-dependent.

Do you know which line is throwing the error? Is it the line where you import pyphi or something else?

And which version of PyPhi are you using?

rlmv commented 6 years ago

Seems related to https://bugs.python.org/issue20784#msg213126. Also see https://hg.python.org/cpython/rev/d575398d1916. Not sure whether this applies to some 3.4 minor releases and not others, but I think the easy fix is to just use collections.Sequence instead of collections.abc.Sequence.

rlmv commented 6 years ago

669f1b5 should fix this. I'm closing this issue now - @fischerdom, can you reopen if it is still an issue?

fischerdom commented 6 years ago

Alright, thanks for your help!