wmbeers / cmv-app

CMV - The Configurable Map Viewer - A community supported open source mapping framework built with the Esri JavaScript API and the Dojo Toolkit
https://demo.cmv.io/
MIT License
1 stars 2 forks source link

All project features should be visible by default, not just polylines. #23

Closed wmbeers closed 4 years ago

wmbeers commented 4 years ago

https://est-dev-team.slack.com/archives/CHRMG0NNM/p1586789652033800

Mike Apr 13th at 10:54 AM @Bill map viewer issue with the Projects (Draft/Currently in Review/Previously Reviewed)

Mike 7 days ago By default, the only sub-layer visible for these is Analysis Area Features > Lines

Mike 7 days ago I think it should be Analysis Areas instead, or all of Points/Lines/Polygons

Mike 7 days ago otherwise a project like #14447 is not visible in the default view image.png image.png

Bill 7 days ago Sounds reasonable. That's defined in the map service. I can override it in the viewer, but it's much better if Lex/Danny set it that way in the MXD that defines the service.

Mike 7 days ago @Danny @Lex tag you're it :laughing:

Bill 7 days ago (For clarity, I'm not just being lazy, it would be a maintainance headache, because if we ever add another layer, or change the order/folder structure in any way, and the viewer-side config wasn't changed accordingly, very weird things would happen.) :+1: 1

Danny 7 days ago I can change it to whatever you like, so would you rather see Analysis Areas, or alll Points/Lines/Polygons?

Mike 7 days ago making all feature types visible by default looks better to me. the analysis areas appear kind of fuzzy and blotchy compared to the sharper features. or change the default renderer for analysis areas, but it may be that way for a reason.

Mike 7 days ago points/lines/polys visible by default please

Danny 7 days ago Roger. Which particular services are these?

Bill 7 days ago https://leo.at.geoplan.ufl.edu/arcgis/rest/services/oem_services/PREVIOUSLY_REVIEWED_DEV/MapServer, https://leo.at.geoplan.ufl.edu/arcgis/rest/services/oem_services/ETAT_REVIEW_DEV/MapServer, https://leo.at.geoplan.ufl.edu/arcgis/rest/services/oem_services/ELIMINATED_DEV/MapServer, and https://leo.at.geoplan.ufl.edu/arcgis/rest/services/secure_services/DRAFT_PROJECTS_DEV/MapServer, and their equivalents on stage and prod.

Danny 7 days ago Hmm, that is what confused me. All layers are on by default in those services. etat_rev_dev.PNG etat_rev_dev.PNG

Bill 7 days ago Yep, I was just checking the config and it I'm overriding it in the config. :back: 1 :+1: 1

Bill 7 days ago So I can change it to default to the service definition, or just set it there, since I'm already down that road.

Bill 7 days ago Do we anticipate that we'll ever change these services? Re-order them, add or remove a layer, change the folder structure?

Danny 7 days ago As far as I know, this is the structure that we want and it should be staying this way. That being said, I am merely a soldier in this fight. I'll check with Lex. :+1::skin-tone-2: 1

Bill 7 days ago And now I'm wondering why I have it set to only have lines on by default. I don't recall any feedback from Ruth or users that we'd want it that way, but I don't know why I would have gone through the effort to add the code necessary to override the default presentation.

Bill 7 days ago I committed the change on 1/22 with the comment Changing default presentation of projects Only showing the alternative lines. I considered removing this as an operational layer, but it seems to break the CMV a bit (throws an exception, but then seems to function) if there isn't at least one operational layer present.

Was there a time when these map services had nothing turned on, and I added this so that at least lines were visible.?

Bill 7 days ago ("Considered removing this as an operational layer" means changing how the service is loaded in the CMV, removing it from a section of the config called operationalLayers, to something I add on-the-fly, like other layers.)

Danny 7 days ago I'm pretty sure they were always turned on, but early on there may have been no features present.

Bill 7 days ago I'll ask Ruth in this afternoon's meeting. Seems plausible to me that maybe we thought it was too busy to have everything turned on, and I just went too far in paring it down.

Mike 7 days ago i really don't think that's the case, why would we not want to see some entire projects or features of projects

Bill 7 days ago By "everything" I mean all the other layers, like termini and buffers.

Mike 7 days ago oh, right, yeah i would not want to see all that. but i do want to see all feature types of projects in these layers, not just the lines

Bill 7 days ago I agree. :+1: 1

Danny 7 days ago Lex doesn't foresee any changes with these services. He'll get with you guys at the 1:00 meeting.

Bill 7 days ago Thanks Danny. Since I already have the code in place to set visible layers, I'll just add the indexes of the point and poly layers to the config.

Bill 7 days ago (I did find an unattributed comment from some rough notes I took way back in December 2018: Lines are labelled even when the Features/Labels/Line Labels are turned off. When turned on, duplicate labels appear. Default visibility: lines on, labels and buffers off I don't know if that was just my thoughts or notes from a meeting. Don't have any more detailed notes with me here. I'll bet "lines" was just shorthand for "project features".)

wmbeers commented 4 years ago

Verified on production.

wmbeers commented 4 years ago

Reopening because similar change needed for public site map

wmbeers commented 4 years ago

Merged and deployed to public site.