wmbeers / cmv-app

CMV - The Configurable Map Viewer - A community supported open source mapping framework built with the Esri JavaScript API and the Dojo Toolkit
https://demo.cmv.io/
MIT License
1 stars 2 forks source link

Show draft features from projects if available and authorized, fall back to milestone max if draft not available or user not authorized #58

Closed wmbeers closed 3 years ago

wmbeers commented 3 years ago

In a situation where an alt of a given project has been through review, but a draft alt added after that review, results in the draft alt not showing up in the map after a call to addProjectToMap. This is because the routine adds the milestone max, which includes only the first alt (the second, still being draft, isn't in that layer), then stops if it finds something. It only adds draft if not found in milestone max.

See email from Lauren Brooks 10/30/2020:

Greetings, Help Desk!

We are hoping to release ETDM Project #14334 to the ETAT next week. We just received comments from OEM. Jonathan Turner (OEM) indicted that you can’t see the linework in the EST for Segment 2 of the referenced project. He’s correct… for some reason it is hidden under the road network of the base map.

What do we need to do to correct this. Any assistance you can provide would be greatly appreciated. Thanks!

Lex proposed adding a new milestone event like "ready for review" to push the draft alt to milestone max. Mike proposes we just invert the search and show draft if available, and only milestone max if user doesn't have draft access or nothing found in draft.

wmbeers commented 3 years ago

Note: project 9291 is a good candidate for testing--it has very different geometry in draft than the most recent milestone. It exists this way on dev and stage, and possibly prod. Other candicates can be found with this sql:


select *
from draft_alternatives d
inner join milestone_max_alternatives mma
    on d.project_alt = mma.fk_project_alt
where d.shape <> mma.shape;
wmbeers commented 3 years ago

This issue has been incorporated into #67. We can close this when that issues is complete.