wmcadigital / wmn-disruptions

Disruptions section of the West Midlands Network website
https://disruptions.wmnetwork.co.uk
2 stars 2 forks source link

Fixing website design issues and enhancements #654

Closed sudheer-rk closed 2 years ago

sudheer-rk commented 2 years ago

Updated website header and footer Updated tag to "Disruptions - Transport for West Midlands" Fixed feedback link in the beta banner Updated replan journey links/button redirect link to tfwm.org.uk Design issues - Align the filter options in line with the 'Disruptions' headline to match Tram zones microjourney. Change the styling on the map buttons to match those used on the map component Change the button styling for map and list formatting to match those used on the Tram zones microjourney </p> <p>Upgraded node and other react project dependencies</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/gitguardian[bot]"><img src="https://avatars.githubusercontent.com/in/46505?v=4" />gitguardian[bot]</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <h4>⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.</h4> <p>Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.</p> <details> <summary>🔎 Detected hardcoded secrets in your pull request</summary> <br> | GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [1065342](https://dashboard.gitguardian.com/incidents/1065342?occurrence=52076073) | Generic High Entropy Secret | 10b21834da1e2069324fd8b9e943003623975010 | .env.development | [View secret](https://github.com/wmcadigital/wmn-disruptions/commit/10b21834da1e2069324fd8b9e943003623975010#diff-da4c41d59c967338247b2f0ea6d845ab05171f942fd9521b96d3304202185db9L4) | | [1065341](https://dashboard.gitguardian.com/incidents/1065341?occurrence=52076074) | Generic High Entropy Secret | 10b21834da1e2069324fd8b9e943003623975010 | .env.production | [View secret](https://github.com/wmcadigital/wmn-disruptions/commit/10b21834da1e2069324fd8b9e943003623975010#diff-48f73ea2653e45c41f31afc2d42dfde14d8caf26d8dd24d3d2a81a52604f4cb6L3) | | [1065342](https://dashboard.gitguardian.com/incidents/1065342?occurrence=52076075) | Generic High Entropy Secret | 10b21834da1e2069324fd8b9e943003623975010 | netlify.toml | [View secret](https://github.com/wmcadigital/wmn-disruptions/commit/10b21834da1e2069324fd8b9e943003623975010#diff-ab8f79b68b7adff7a07db953bf453f3c5aa6ade98d2b1b67d8432b36392489edL14) | </details> <details> <summary>🛠 Guidelines to remediate hardcoded secrets</summary> <br> 1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation. </details> <hr /> <p><sup>🦉 <a href="https://dashboard.gitguardian.com/auth/login/?utm_medium=checkruns&amp;utm_source=github&amp;utm_campaign=cr1">GitGuardian</a> detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.<br/><br/>Our GitHub checks need improvements? <a href="https://050127dayho.typeform.com/to/KmeAPTMk">Share your feedbacks</a>!</sup></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>