search

wmcbrine / MultiMail

Offline reader for QWK, Blue Wave, etc. Multi-platform, curses-based.
https://wmcbrine.com/MultiMail
34 stars 7 forks source link

Added support for QWKE 'To' kludge lines #14

Closed rswindell closed 5 years ago

rswindell commented 5 years ago

Added support for the parsing and generating of 'To' QWKE kludge lines with values of up to 71 characters in length.

This fixes the '25 char' to-field limit when using a QWKE compatible BBS/door.

Also fixed a couple of off-by-one errors in the maximum subject line lengths (actually 71 printable chars, not 72).

This is a "low touch" change. I would prefer to use more macros/enums for magic numbers (e.g. 25, 71) and change the kludge line parsing to allow kludge lines in any order. But those improvements can come later once this patch is accepted and tested.

Also needed, to support "From:" QWKE kludge lines.

I've actually been sitting on this patch since 2011; glad to get it pushed out (and hopefully merged), finally.

wmcbrine commented 5 years ago

Eh, I literally just today did pretty much this, on a bug report from "g00r00". (That's not you, is it? I was going to have him test it more before I committed it, but since this is here now...)

rswindell commented 5 years ago

No, it's not me (g00r00 writes Mystic BBS). I've had this patch sitting around since 2011. I just saw a recent discussion regarding this limitation in multimail and thought I'd try again to get it submitted/merged. It's not perfect (note the kludge field ordering requirement) - but it's a start.