search

wmcbrine / pytivo

pyTivo is both an HMO and GoBack server. Similar to TiVo Desktop pyTivo loads many standard video compression codecs and outputs mpeg2 video to the TiVo. However, pyTivo is able to load MANY more file types than TiVo Desktop.
http://pytivo.org/
127 stars 42 forks source link

newest ffmpeg build fails pad_check() in transfers.py #14

Closed ghost closed 10 years ago

ghost commented 11 years ago

I built the latest ffmpeg last night. Looks like the output of the --filters switch changed so that the line no longer starts with ^pad

Relevant lines:

     381         cmd = [config.get_bin('ffmpeg'), '-filters']
    ...
     385         for line in filters:
     386             if line.startswith('pad'):
     387                 pad_style = NEW_PAD

OLD: (ffmpeg version 0.8.6-4:0.8.6-0ubuntu0.12.04.1,) $ ffmpeg -filters | grep pad
pad Pad input image to width:height...

NEW: (ffmpeg version git-2013-09-14-8728360 .... built on Sep 14 2013 01:49:09)

$ ffmpeg -filters (there is a header explaining the abbreviations) Filters: T. = Timeline support .S = Slice threading A = Audio input/output V = Video input/output N = Dynamic number and/or type of input/output | = Source or sink filter

(and then the pad line looks like this): .. pad V->V Pad input image to width:height...

So the pad line no longer matches "if line.startswith('pad'):". It should.

wmcbrine commented 11 years ago

I'm inclined to solve this in the crudest way possible: By ripping out pad_check() altogether, and all the old-style pad code along with it. I was half-inclined to do that already, before I read this. But if someone has a case to make that the old-style code is still needed, please make it here.

wmcbrine commented 11 years ago

OK, I've committed that fix... leaving this open in case anyone wants to comment.