search

wmcbrine / pytivo

pyTivo is both an HMO and GoBack server. Similar to TiVo Desktop pyTivo loads many standard video compression codecs and outputs mpeg2 video to the TiVo. However, pyTivo is able to load MANY more file types than TiVo Desktop.
http://pytivo.org/
127 stars 42 forks source link

Possible code error in plugins/video/video.py #31

Open itsayellow opened 4 years ago

itsayellow commented 4 years ago

Lines 216-220:

        if ((int(vInfo['vHeight']) >= 720 and
             config.getTivoHeight >= 720) or
            (int(vInfo['vWidth']) >= 1280 and
             config.getTivoWidth >= 1280)):
            data['showingBits'] = '4096'

I believe getTivoHeight and getTivoWidth should be function calls like so:

        if ((int(vInfo['vHeight']) >= 720 and
             config.getTivoHeight(tsn) >= 720) or
            (int(vInfo['vWidth']) >= 1280 and
             config.getTivoWidth(tsn) >= 1280)):
            data['showingBits'] = '4096'
itsayellow commented 4 years ago

I'm adding another issue in video.py in this Issue because it's concerning the same file.

Line 456:

    def __delitem__(self):

should be:

    def __delitem__(self, key):