wmcmahan / react-native-calendar-events

📆 React Native Module for iOS and Android Calendar Events
MIT License
906 stars 292 forks source link

Avoid iOS crash at all cost #314

Closed MoOx closed 4 years ago

MoOx commented 4 years ago

This allow to skip some part of events (during serialization) that leave an NSLog and also add try/catch with reject for most method that present a risk. This helped me recover errors from JavaScript instead of facing a brutal crash.

@wmcmahan I am very new to objective-c & would like your input on this (asking since I saw you handled some issues yay!)

Better to review without whitespace changes!

Note that this PR is on branch 2.0.0 (I am preparing a release with latest changes that are in master, unreleased, and some others that I tried on the 2.0.0 branch)

Also, should we do something similar for Android or is the way async is handled (from JS) enough to trigger promise rejection if something fails native side?)

Closes #311 Closes #281