Closed superandrew213 closed 8 years ago
Thanks @superandrew213. Looks like it might be something with inaccurate timezone on date components. I'll try and get a fix out soon.
@wmcmahan awesome. Thank you!
@superandrew213, I've pushed a patch to fix (hopefully) strange time shifting bug. Thanks for the help. Cheers!
thanks @wmcmahan but for some reason you can't add any recurring reminders anymore. Non recurring ones still work.
Hmm, I also stopped setting dueDate
on the native side, unless specified in the JS settings object. Maybe that is messing with the recurrence rules if not set.
RNCalendarReminders.saveReminder('title', {
notes: 'notes',
startDate: '2016-10-01T09:45:00.000UTC',
dueDate: '2016-10-01T09:45:00.000UTC',
alarms: [{
date: '2016-10-01T09:45:00.000UTC'
}],
recurrence: 'daily'
});
Yep, it's working with the due date. Could have sworn that I did test it with the due date too. Anyway all good. Thanks!
Will you set the due date on the native side again or will you make it required if recurrence is set?
I could default the dueDate to be the same as the startDate on the native side, if a recurrence rule is set without a dueDate. Would that help, or just make things more confusing?
I think that might help since most of the time the dueDate will be the same as the startDate for recurring reminders. But that's up to you as long as it's in the docs it should be fine either way.
To replicate:
When you click on info in reminders the alarm date is being changed and a due date has been added (which wasn't there when the reminder was added for the first time and is different from the alarm date).