search

wmde / DataValuesJavaScript

JavaScript implementations of all basic DataValue classes, associated parsers and formatters
http://wikiba.se
Other
5 stars 1 forks source link

Remove composer/installers dependency #110

Closed thiemowmde closed 7 years ago

thiemowmde commented 7 years ago

This was introduced with 75343a823dc625bbc2966490b3d5001988837108 by @JeroenDeDauw. I tried to understand why, but can't figure it out. The component consists of nothing but a series of …Installer classes, including a MediaWikiInstaller one. I can't find usages of these classes, neither today not back then when the dependency was introduced.

Either this was added by mistake, or (more likely) I'm missing something. @JeroenDeDauw, can you please have a look?

JeroenDeDauw commented 7 years ago

Ugh, long ago :) I don't quire remember what was going on here, but if IIRC, then this stuff is needed for packages with type "mediawiki-extension", so they get installed on the location expected for extensions. Looking at composer.json, this package does not (or no longer) have that type, in which case this dependency is not needed.

addshore commented 7 years ago

Looks like there is a conflict?

I'd be happy to merge this otherwise!

thiemowmde commented 7 years ago

Conflicted because of #111. Manually rebased now.

addshore commented 7 years ago

We will need a new release in order for this to be able to get pulled into mediawiki/vendor.

thiemowmde commented 7 years ago

Please merge #113 for a release.