search

wmde / DataValuesJavaScript

JavaScript implementations of all basic DataValue classes, associated parsers and formatters
http://wikiba.se
Other
5 stars 1 forks source link

Renamed Value*Factory to Value*Store #35

Closed snaterlicious closed 10 years ago

snaterlicious commented 10 years ago

Since the factory is not creating instances, the label "store" is more applicable.

thiemowmde commented 10 years ago

Doesn't this need a version to be increased or something like that? Or is this only internally used and doesn't matter?

JeroenDeDauw commented 10 years ago

Looks like this targeted 0.4, which has already been released. So this needs a fix in the readme now. (If it is not clear something will make it into a release, then it is often better to not include the rel notes update in the commit, and make it right after it got merged. Then one does not run into this issue.)