search

wmde / DataValuesJavaScript

JavaScript implementations of all basic DataValue classes, associated parsers and formatters
http://wikiba.se
Other
5 stars 1 forks source link

[WIP] Reimplement removed constructor naming #43

Open thiemowmde opened 10 years ago

thiemowmde commented 10 years ago

This ReferenceError: evilsSeed is not defined is driving me crazy. I can always reproduce it by simply shift+reloading a page in my local Wikibase Repo. This is a huge pain when debugging.

Update: #45 removes this feature. It should be readded when the PhantomJS bug mentioned below got fixed and the Travis tests pass.

thiemowmde commented 10 years ago

@mariushoch @filbertkm @tobijat Rage! This stupid bug keeps wasting my time. Merge! Also: WTF is wrong with Travis?

mariushoch commented 10 years ago

Long story short: Neither Function.apply nor Function.bind exist in the JS engine used by phantomjs. There's a polyfill for Function.bind1 but that doesn't work here as Function.apply also doesn't exist (and I couldn't find a polyfill for that).

I would suggest to completely remove this named functions code for now... the problems/ costs caused by that are just to huge (I just spent ages debugging phantomjs...).

thiemowmde commented 10 years ago

@mariushoch What now? I spent months debugging this issue. I'm now 100% sure this is the right way to do it. The tests pass in all browsers. Are you telling me we are disallowed to use JavaScript correctly because Travis uses a broken JS engine?

mariushoch commented 10 years ago

I'm not sure how to move forward here... either kill the whole named function thing or allow the tests to fail until phantomjs gets fixed or we run the tests in another way, I guess.

mariushoch commented 10 years ago

No longer needed as we decided to remove evilsSeed completely

thiemowmde commented 10 years ago

Erm, no? Why? Didn't I explained that in #45?