GlobeCoordinate: support other globes

wmde / DataValuesJavaScript

JavaScript implementations of all basic DataValue classes, associated parsers and formatters

http://wikiba.se

Other

5 stars 1 forks source link

GlobeCoordinate: support other globes #94

Closed ricordisamoa closed 8 years ago

ricordisamoa commented 8 years ago

Prefer the injected value instead of the hard-coded 'http://www.wikidata.org/entity/Q2'.

Add tests.

Bug: T105321

thiemowmde commented 8 years ago

The PHP data value defaults to Q2 (Earth) when no globe is given, see https://github.com/DataValues/Geo/blob/master/src/Values/GlobeCoordinateValue.php#L47. The same should happen here. This is especially important to not make this a breaking change.
Please add test cases for the changed behaviour.

thiemowmde commented 8 years ago

Thanks a lot for changes. I just wanted to merge this but found that Fomafix is right: equals must compare the globe. Don't forget to add tests for this.

Notes:

getDecimal is fine. Don't add the globe there.
Don't add type checks. The existing properties do not have type checks too. I think this is fine. I think performance is more important than absolute type safety here.

ricordisamoa commented 8 years ago

Right. Thank you.