search

wmde / DataValuesJavaScript

JavaScript implementations of all basic DataValue classes, associated parsers and formatters
http://wikiba.se
Other
5 stars 1 forks source link

Add support for precision null to GlobeCoordinate #96

Closed thiemowmde closed 8 years ago

thiemowmde commented 8 years ago

Before #53 the implementation already supported both null and undefined precisions, but this was never tested properly, only slightly with a lazy assert.equal( …, null ) that accepts undefined as null. #53 broke this feature, but not the test, because it was never calling equals with an undefined precision.

The backend also supports precision null, see https://github.com/DataValues/Geo/blob/master/src/Values/GlobeCoordinateValue.php.

thiemowmde commented 8 years ago

I just realized this is a duplicate of #91 from more than two months ago. :-(