PHP 8 support - Githubissues

wmde / Diff

䷂ Library for diffing, patching and representing differences between objects

BSD 3-Clause "New" or "Revised" License

200 stars 15 forks source link

PHP 8 support #126

Closed makstech closed 3 years ago

makstech commented 3 years ago

In this pull request:

PHP_CodeSniffer was updated to latest v3.6.0 version, it supports PHP 8.
Also, PHP_CodeSniffer has a couple of new rules regarding naming conventions. Excluded these rules, since they require some changes in all files.
Fixed a bug that happens on PHP 8

JeroenDeDauw commented 3 years ago

Added composer.lock to Git, because that's what official docs suggest doing.

That makes sense for applications but not for libraries. The main users of the library will not be affected by the lock file in this repo, so it ends up doing more harm than good.

makstech commented 3 years ago

Added composer.lock to Git, because that's what official docs suggest doing.

That makes sense for applications but not for libraries. The main users of the library will not be affected by the lock file in this repo, so it ends up doing more harm than good.

Wondering, what harm would it be? :)
A quick run through all questions on StackOverflow, the usual answer is "it does not really matter".
But no problemo, can easily remove it

makstech commented 3 years ago

Reverted most changes
Excluded new naming conventions
Returned PHP 7.2

mariushoch commented 3 years ago

Thank you for tackling this!

makstech commented 3 years ago

No problem :)
I want to update the package in the project, how soon can I expect a new version release?