search

wmde / Diff

䷂ Library for diffing, patching and representing differences between objects
BSD 3-Clause "New" or "Revised" License
200 stars 15 forks source link

Add PHP 8.1 compatibility #132

Closed mariushoch closed 2 years ago

mariushoch commented 2 years ago

Contains #129, one additional backwards compatibility fix and silences some deprecation notices from us mocking the DiffOp interface.

Tested with PHP 8.1.10.

mariushoch commented 2 years ago

Sending the coverage to Scrutinizer didn't work and I suspect that might be caused by us using PHP 8.1.2 for that, thus we're now sending the coverage data from the 8.0 job.

mariushoch commented 2 years ago

Sending the coverage to Scrutinizer didn't work and I suspect that might be caused by us using PHP 8.1.2 for that, thus we're now sending the coverage data from the 8.0 job.

That was actually from our phpunit being to old to generate coverage on PHP 8... thus I made the PHP 7.4 job upload the coverage and that should finally work.

lucaswerkmeister commented 2 years ago

Perhaps GitHub is showing me outdated data, but to me it looks like PHP 8.0, not 7.4, is being used to send coverage data?

mariushoch commented 2 years ago

Perhaps GitHub is showing me outdated data, but to me it looks like PHP 8.0, not 7.4, is being used to send coverage data?

Hm, looks good to me... maybe the UI didn't yet fully digest the force push?