Add Diff::equals - Githubissues

wmde / Diff

䷂ Library for diffing, patching and representing differences between objects

BSD 3-Clause "New" or "Revised" License

200 stars 15 forks source link

Closed thiemowmde closed 9 years ago

thiemowmde commented 9 years ago

Note that I'm not using the Comparable interface here to not introduce a weird dependency that's not crucial.

I squished some basic refactoring in here. I can split this into separate patches if you like. No problem, just tell me.

Inline two trivial methods (looks like they were overriding protected parent methods before but don't do any more).
Some more specific type hints.
Favor bool and int shortcuts.

JeroenDeDauw commented 9 years ago

Code looks good. Don't forget the release notes.