search

wmde / Diff

䷂ Library for diffing, patching and representing differences between objects
BSD 3-Clause "New" or "Revised" License
200 stars 15 forks source link

Revert "Remove redundant since tags" #55

Closed JeroenDeDauw closed 8 years ago

JeroenDeDauw commented 8 years ago

These are not all redundant. Commit with -2 was merged without any stated reason, so reverting.

Reverts wmde/Diff#51

mariushoch commented 8 years ago

I don't really care much for whether we do it in this way or the other, because no information is lost anyway. All the removed @since tags equaled the ones of the classes/ interfaces they were in (I just checked this again).

JeroenDeDauw commented 8 years ago

If you do not care much about it, then why merge over a -2? Did you not see it? Loose from if this change makes sense or not, it seems to be that creating friction between people by doing this easily outweighs any gains.

Information is lost: if something states explicit compat then you know it is compat. If it does not state that, you do not know if it is compat or not, since a tag might have been not added. This is relevant in classes where new public elements where added after introduction, which includes ones touched here.

mariushoch commented 8 years ago

Let's go back to the initial state… I didn't see the -2. It would be nice if the Github code review tools were more practical for our use cases :/

I see the point of having information explicitly encoded in each methods phpdoc, but I also see why that is redundant.