wmde / Diff

䷂ Library for diffing, patching and representing differences between objects
BSD 3-Clause "New" or "Revised" License
200 stars 15 forks source link

Remove MediaWiki registration and release 2.2 #84

Closed legoktm closed 7 years ago

legoktm commented 7 years ago

@addshore

JeroenDeDauw commented 7 years ago

This is cool and all but I am worried that the branch 21x will be interpreted by composer as version 21. Normally the name would be 2.1.x

legoktm commented 7 years ago

Based on https://packagist.org/packages/diff/diff that doesn't have appeared to happen

JeroenDeDauw commented 7 years ago

It won't be listed as a version there I think.

But do try

composer require diff/diff 21

or

composer require diff/diff *

I'm not on a dev box myself ATM. I've seen purely numerical branch names cause this problem. Though this was over a year ago, so things might have changed. And perhaps the x at the end of the name prevents the problem.

legoktm commented 7 years ago
km@km-tp ~/p/sandbox> composer require diff/diff 21
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package diff/diff 21 exists as diff/diff[0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0, 1.0.1, 2.0.0, 2.1.0, 2.2.0, 3.0.0, dev-21x, dev-composerMd, dev-listChange, dev-listDiffer, dev-master, 3.0.x-dev, dev-upperbound] but these are rejected by your constraint.
km@km-tp ~/p/sandbox> composer require diff/diff \*
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Installing diff/diff (3.0.0): Downloading (100%)         
Writing lock file
Generating autoload files
JeroenDeDauw commented 7 years ago

Great. Thanks for checking!

JeroenDeDauw commented 7 years ago

I realized that this is still off though. Either this branch is meant to be temporary and can be deleted or it is meant to stay and should have a name reflecting what it is: a 2.x branch. I've thus renamed it as it is not a 2.1.x branch. The composer branch alias is also wrong now, fixed with https://github.com/wmde/Diff/pull/85