wmde / LOSH-Frontend

1 stars 3 forks source link

Feedback frontend detail page, order and display of properties #67

Closed jdittrich closed 2 years ago

jdittrich commented 3 years ago

This is a review of the frontend detail page based on the OHLOOM, which seems to be our most richly populated item.



image

jdittrich commented 3 years ago

@moedn , could you help us with the meaning of the timestamp and mapping of the values in cube(size = [400,350,150]) to width/length/height?

moedn commented 3 years ago

sure:

moedn commented 3 years ago

My comment on the detail page:

botoxparty commented 3 years ago
moedn commented 3 years ago
botoxparty commented 3 years ago
botoxparty commented 3 years ago

@jdittrich How should those OpenSCAD primitives translate when parsed to a string?

jdittrich commented 3 years ago

@jdittrich How should those OpenSCAD primitives translate when parsed to a string?

cube([10,31,40]) → Outer Dimensions: 10mm×31mm×40mm sphere(r = 150) → Outer Dimensions: 15mm radius cylinder(h=15, r=10) → Outer Dimensions: 15mm height, 10mm radius.

For the cube, please use the × (multiplication sign) not the x

moedn commented 3 years ago

sorry for the late reply; I'm at a seminar since yesterday and there wasn't much internet access surprisingly…

regarding SPDX:

regarding CPC: :ok_hand: :)

botoxparty commented 3 years ago

For an example of the SPDX issue, you can see the raw values for the spdxLicense field are rendered in the table on the test site:

You can find the OHLOOM on page 6.


I have updated the design to match the latest mock in Figma, mixed with some of the feedback about the order of the items.

I am off this project for the next week, when I return i'll be implementing the rest of the feedback regarding UI/UX as well as implementing a solution for the filtering and sorting.

In the mean time, it would be helpful if you would do review and finalise any feedback of the latest implementation (see OHLOOM here, verify some other items that aren't populated with as much data)

Download Bundle button With repositories hosted on Appropedia, I can't seem to find any download link to generate for the 'Download Bundle' button. Should this button appear on appropedia imported items?

jdittrich commented 3 years ago
moedn commented 3 years ago

For an example of the SPDX issue, you can see the raw values for the spdxLicense field are rendered in the table on the test site:

You can find the OHLOOM on page 6.

Alright, thanks! Seems like there's a bug in the Crawler. Reported it and asked for a fix.

In the mean time, it would be helpful if you would do review and finalise any feedback of the latest implementation (see OHLOOM here, verify some other items that aren't populated with as much data)

Download Bundle button With repositories hosted on Appropedia, I can't seem to find any download link to generate for the 'Download Bundle' button. Should this button appear on appropedia imported items?

Good point. Appropedia changed it's structure a couple of weeks ago, so we're having trouble getting their data. I'm in exchange with their head to fix this. Not sure if we will get downloadable files TBH\ Suggestion: Can we gray out the Download Bundle button for projects with no downloadable files available?

--

another point:

jdittrich commented 3 years ago

Suggestion: Can we gray out the Download Bundle button for projects with no downloadable files available?

Or just don't have it, as the user can't change anything about this

moedn commented 3 years ago

whatever fits best from the UX perspective :)

ckawohl-wmde commented 2 years ago

This hasn't been touched in months. I will close it.