Closed jdittrich closed 2 years ago
@moedn , could you help us with the meaning of the timestamp and mapping of the values in cube(size = [400,350,150])
to width/length/height?
sure:
timestamp
is the timestamp of the commit this version of the OSH refers to. In this case, v1.0.0 is the tag for the commit 834222370f34ad2a07d0e41d09eb54378573b8c3
which was done on 27.7.2021cube(size = …)
is a OpenSCAD primitive;
outerDimensions
are defined as OpenSCAD primitivesMy comment on the detail page:
image
, functional description
,version
, license
, licensor
, organisation
) to the top of the pageRelated URLs
with Linked Files
or something like that ('related URLs' sounds like 'further information', but those should be essential files)licensor
from organisation
→ 2 distinct fields[D03D 35/00](https://worldwide.espacenet.com/patent/cpc-browser#!/CPC=D03D35/00) (Smallware looms, i.e. looms for weaving ribbons or other narrow fabrics)
CPC Patent Class
value is linked to classificationIPCInventive
on their side (see ontology for detials))D03D 35/00
whereas the API identifies it as D03D35-00
(see this API request), is it expected that all patent classes will follow a certain format that can be parsed to retrieve the full designation from the API?The SPDX items don't all resolve as URLs, why does this one test item (Q438) return a URL?
Ok i will make the assumption that all spaces should be removed and forward slashes converted to -
.
@jdittrich How should those OpenSCAD primitives translate when parsed to a string?
@jdittrich How should those OpenSCAD primitives translate when parsed to a string?
cube([10,31,40]) → Outer Dimensions: 10mm×31mm×40mm sphere(r = 150) → Outer Dimensions: 15mm radius cylinder(h=15, r=10) → Outer Dimensions: 15mm height, 10mm radius.
For the cube, please use the × (multiplication sign) not the x
sorry for the late reply; I'm at a seminar since yesterday and there wasn't much internet access surprisingly…
regarding SPDX:
regarding CPC: :ok_hand: :)
For an example of the SPDX issue, you can see the raw values for the spdxLicense
field are rendered in the table on the test site:
You can find the OHLOOM on page 6.
I have updated the design to match the latest mock in Figma, mixed with some of the feedback about the order of the items.
I am off this project for the next week, when I return i'll be implementing the rest of the feedback regarding UI/UX as well as implementing a solution for the filtering and sorting.
In the mean time, it would be helpful if you would do review and finalise any feedback of the latest implementation (see OHLOOM here, verify some other items that aren't populated with as much data)
Download Bundle button With repositories hosted on Appropedia, I can't seem to find any download link to generate for the 'Download Bundle' button. Should this button appear on appropedia imported items?
For an example of the SPDX issue, you can see the raw values for the
spdxLicense
field are rendered in the table on the test site:You can find the OHLOOM on page 6.
Alright, thanks! Seems like there's a bug in the Crawler. Reported it and asked for a fix.
In the mean time, it would be helpful if you would do review and finalise any feedback of the latest implementation (see OHLOOM here, verify some other items that aren't populated with as much data)
Documentation Readiness Level
seems to link to the wrong comment
ODRL-5
should link to the rdfs:comment of ODRL-5 (mature release), instead it seems to link to OTRL-5Download Bundle button With repositories hosted on Appropedia, I can't seem to find any download link to generate for the 'Download Bundle' button. Should this button appear on appropedia imported items?
Good point. Appropedia changed it's structure a couple of weeks ago, so we're having trouble getting their data. I'm in exchange with their head to fix this. Not sure if we will get downloadable files TBH\
Suggestion: Can we gray out the Download Bundle
button for projects with no downloadable files available?
--
another point:
Designed parts
should link to an own detail page of that part. That detail page would look almost exactly like this project detail page. The clamp ring gives a good example of which sort of data is expected for partsSuggestion: Can we gray out the Download Bundle button for projects with no downloadable files available?
Or just don't have it, as the user can't change anything about this
whatever fits best from the UX perspective :)
This hasn't been touched in months. I will close it.
This is a review of the frontend detail page based on the OHLOOM, which seems to be our most richly populated item.