update phpunit to 8.5 - Githubissues

wmde / Number

Numerical value objects, parsers and formatters

Other

18 stars 6 forks source link

update phpunit to 8.5 #130

Closed rosalieper closed 4 years ago

rosalieper commented 4 years ago

Use phpunit TestCase
Fix failing test due to phpunit upgrade.
Add new testBase abstract classes
ChangegetAmount()->getValue to getAmount()->getValueFloat in tests. In this case comparing float values seem more reasonable than comparing stringyfied decimals.
See: https://phabricator.wikimedia.org/T260915

rosalieper commented 4 years ago

fails due to dependency on outdated DataValue/DataValue

toban commented 4 years ago

LGTM.

One difference I noticed running the tests locally on master and then this branch is there is now a Warning about the following.

1) Warning
The data provider specified for ValueFormatters\Test\QuantityHtmlFormatterTest::testGivenHtmlCharacters_formatEscapesHtmlCharacters is invalid.
PHPUnit\Framework\MockObject\RuntimeException: Trying to configure method "getUncertaintyMargin" which cannot be configured because it does not exist, has not been specified, is final, or is static
/home/toan/Documents/dev/Number/tests/ValueFormatters/QuantityHtmlFormatterTest.php:75
/home/toan/Documents/dev/Number/tests/ValueFormatters/QuantityHtmlFormatterTest.php:171

rosalieper commented 4 years ago

LGTM.

One difference I noticed running the tests locally on master and then this branch is there is now a Warning about the following.

1) Warning
The data provider specified for ValueFormatters\Test\QuantityHtmlFormatterTest::testGivenHtmlCharacters_formatEscapesHtmlCharacters is invalid.
PHPUnit\Framework\MockObject\RuntimeException: Trying to configure method "getUncertaintyMargin" which cannot be configured because it does not exist, has not been specified, is final, or is static
/home/toan/Documents/dev/Number/tests/ValueFormatters/QuantityHtmlFormatterTest.php:75
/home/toan/Documents/dev/Number/tests/ValueFormatters/QuantityHtmlFormatterTest.php:171

warning fixed.