Use Wikibase's snakview for the SimpleQuery special page

wmde / WikibaseQuery

DISCONTINUED: Wikibase Query adds query capabilities to Wikibase Repo

Other

2 stars 2 forks source link

Use Wikibase's snakview for the SimpleQuery special page #13

Closed adrianheine closed 10 years ago

adrianheine commented 10 years ago

Todo:

Style snakview
Make non-snakview special page appearance match the snakview style
~~Support valueless snaks as soon as the backend does so as well~~

JeroenDeDauw commented 10 years ago

What is this TODO list supposed to indicate? Are these things that need to be done before this is merged? Are these things you still need to do afterwards?

adrianheine commented 10 years ago

That's what needs to be done before this is merged.

adrianheine commented 10 years ago

From my point of view, the TODOs are addressed.

JeroenDeDauw commented 10 years ago

Looks good to me. Except that the JS is not tested at all. So I guess someone needs to verify that first

adrianheine commented 10 years ago

I've splitted the code up to be more testable. Where would you want those qunit tests to be put? Currently, tests/ only has phpunit tests.

JeroenDeDauw commented 10 years ago

Where would you want those qunit tests to be put? Currently, tests/ only has phpunit tests.

I'd move those to tests/phpunit and add a tests/qunit.

JeroenDeDauw commented 10 years ago

This amend approach does mean there is no diff between the old version and the new one :(

adrianheine commented 10 years ago

That's right (and bad), although you don't really have diffs between change revisions in gerrit, either, if you rebased the commit.

JeroenDeDauw commented 10 years ago

Rebased against master

Tests passing \o/

JeroenDeDauw commented 10 years ago

My review is still +1