search

wmde / WikibaseQuery

DISCONTINUED: Wikibase Query adds query capabilities to Wikibase Repo
Other
2 stars 2 forks source link

Use phpunit 3.7 for compat with mediawiki for travis #19

Closed filbertkm closed 10 years ago

filbertkm commented 10 years ago

Until https://gerrit.wikimedia.org/r/#/c/131488/ is merged, which will allow phpunit 4.1 to work.

thiemowmde commented 10 years ago

@filbertkm Why does it say that Travis errored? Looks like a misquote.

filbertkm commented 10 years ago

@thiemowmde because composer.json pulls wikibase-query-engine master which is incompatible.

PHP Fatal error: Class 'Wikibase\Database\MediaWiki\MediaWikiQueryInterface' not found in

(we are doing the same thing in Wikibase for using 3.7, as done in the pull request. I suggest to merge this one, since we see it works in Wikibase, then sort out the composer.json issues / review the other pull requests)

filbertkm commented 10 years ago

to add, that happens during the database update (update.php) step so travis is not able to setup and can't even begin to run tests.

mariushoch commented 10 years ago

We did the same thing for Wikibase, so this should be good to go