search

wmde / WikibaseReconcileEdit

GNU General Public License v2.0
3 stars 3 forks source link

Rename i18n messages #45

Closed guergana closed 3 years ago

guergana commented 3 years ago

Bug: T284051

guergana commented 3 years ago

I don’t think we should put the class name into all of those messages – that just means the message key will become outdated again the next time we move the code around. I think the message keys should try to be more general. WDYT?

It's a good idea. Tho, to be fair it also makes the messages much clearer than without the class name... Changing the name of the class is also not a big deal. :thinking:

guergana commented 3 years ago

I don’t think we should put the class name into all of those messages – that just means the message key will become outdated again the next time we move the code around. I think the message keys should try to be more general. WDYT?

It's done!