search

wmdiem / euclid-wm

Automatically exported from code.google.com/p/euclid-wm
5 stars 2 forks source link

undefined reference to find_handler FreeBSD #57

Open anastmag opened 8 years ago

anastmag commented 8 years ago

Hi @wmdiem. Last days i'm trying to make a port for your latest euclid-wm fetched from github.

When compiling using gnu make there is an error for function 'find_handler'

/tmp/euclid-menu-a120af.o: In function 'loop': /usr/home/mag/euclid_wm/euclid-git/euclid-wm/euclid-menu.c:626: undefined reference to 'find_handler' /tmp/euclid-menu-a120af.o: In function 'main': /usr/home/mag/euclid_wm/euclid-git/euclid-wm/euclid-menu.c:763: undefined reference to 'find_handler' cc: error: linker command failed with exit code 1 (use -v to see invocation) gmake: *** [Makefile:27: euclid-menu] Error 1

So i undefined the function 'find_handler' as 'inline' and it compiled successfully, but i'm wondering if it's going to affect functionality of the euclid-wm due to the inline removal. Do you know any better solution ?

Best Mageirias Anastasios

xaizek commented 8 years ago

Not inlining a function won't be noticeable in this case, but if you want to preserve the semantics use static inline. The problem with inline is that if compiler decides to not inline the function it won't be compiled at all and you might get error from the linker, while static inline handles such cases correctly (just inline is valid, but for other use cases).

wmdiem commented 8 years ago

Xaizek, thanks for handling the issue.

Other points: First off, Mageirias, thanks for working on a port! And thanks also for reporting the issue.

Second, while euclid-wm itself is quite stable, euclid-menu should be treated as very much a work in progress (progress which is at the moment stalled). It does have known bugs and performance issues. If I were packaging euclid-wm to distribute, I would consider distributing it (and configured to work out of the box) with dzen. Obviously, it's up to you as packager.

On Tue, Oct 4, 2016 at 4:18 AM, xaizek notifications@github.com wrote:

Not inlining a function won't be noticeable in this case, but if you want to preserve the semantics use static inline. The problem with inline is that if compiler decides to not inline the function it won't be compiled at all and you might get error from the linker, while static inline handles such cases correctly (just inline is valid, but for other use cases).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wmdiem/euclid-wm/issues/57#issuecomment-251337175, or mute the thread https://github.com/notifications/unsubscribe-auth/ANfoM4lx3PgPVEL1Bsilwx-QF75DWypjks5qwhnIgaJpZM4KLXsV .

anastmag commented 8 years ago

Thank you guys for your help. @wmdiem i'm going to add both (dzen and euclid-menu) during the installation so as the user will choose between them.

anastmag commented 8 years ago

Should i add dzen or dmenu ? What do you think ?

xaizek commented 8 years ago

Should i add dzen or dmenu ?

Are they interchangeable? I use dmenu for picking things and dzen2 for displaying status bar, but I don't know how to enable completion and element picking in dzen.

anastmag commented 8 years ago

Ok I thought that dzen is a dmenu alternative. I've never used dzen. Thank you

wmdiem commented 8 years ago

Sorry. That was a thoughtless slip on my part. They serve two different functions. I meant to say that I would consider installing (and configuring Euclid to call) dmenu by default rather than euclidmenu.

Sorry for the confusion. Wmd

On Oct 27, 2016 4:27 PM, "anastmag" notifications@github.com wrote:

Ok I thought that dzen is a dmenu alternative. I've never used dzen

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wmdiem/euclid-wm/issues/57#issuecomment-256774881, or mute the thread https://github.com/notifications/unsubscribe-auth/ANfoM0HVeSAclNWzkv9Vp6DjD3iTNK4Zks5q4RcrgaJpZM4KLXsV .

anastmag commented 8 years ago

My last question.

What is a good one-liner description for euclid-menu?

wmdiem commented 8 years ago

I would describe it as "a keyboard-driven dynamic menu (like dmenu) designed for use with euclid-wm, with the ability to use arbitrary scripts that dynamically generate and update menu entries as the user types."

On Fri, Oct 28, 2016 at 7:04 PM, anastmag notifications@github.com wrote:

My last question.

What is a good one-liner description for euclid-menu?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wmdiem/euclid-wm/issues/57#issuecomment-257049030, or mute the thread https://github.com/notifications/unsubscribe-auth/ANfoM4woOIASg3AfqmG7RJ4DBhg1EDoKks5q4n-HgaJpZM4KLXsV .

anastmag commented 8 years ago

Excellent! Thank you @wmdiem and @xaizek! I'm planning to update the port today