search

wmgeolab / geoBoundaries

geoBoundaries : A Political Administrative Boundaries Dataset (www.geoboundaries.org)
http://www.geoboundaries.org
Other
283 stars 51 forks source link

gB Open CHE ADM2 #2026

Closed lydiatroup closed 1 year ago

lydiatroup commented 2 years ago

Need a new file for this layer, current file is missing many polygons

SidonieH commented 2 years ago

According to wiki, some ADM 1s do not have an ADM2, only an ADM3. This might be what is showing as holes. So not sure if current data is wrong since it is from the Swiss gov data site and updated yearly

SidonieH commented 2 years ago

@lydiatroup

lydiatroup commented 2 years ago

@SidonieH what we currently have on our site doesn't appear to be the same as on the swiss admin site here. The swiss site also states that the 2022 edition includes 5 new communities, so these files may need to be updated eitherway.

could you look into this and let me know (on this issue & tagging me) what you find! thank you for the reminder tag!

SidonieH commented 2 years ago

It looks like all 1-3 need to be replaced for various reasons. 1: boundary in northern canton does not extend far enough north, other minor internal border adjustments 2: minor border adjustments internally (there will still be holes though because some cantons do not have districts) 3: many internal adjustments needed along the south western districts @lydiatroup Do you want me to work on these or wait until they are individual issues?

SidonieH commented 2 years ago

Also ADM 2 seems to have features with the same name so those may need to be merged. Needs further research to ensure there not a reason for that.

lydiatroup commented 2 years ago

@SidonieH I'll make new issues now based off your research. If you could work on the adm2 that would be great since you've already done some research into it.

SidonieH commented 2 years ago

@lydiatroup just want to check that we can use this data. This is the terms of use. It sounds ok but they don't list a specific license. https://www.swisstopo.admin.ch/en/home/meta/conditions/geodata/ogd.html

lydiatroup commented 2 years ago

@SidonieH I'm like 90% sure we can use that, but have messaged Dan about the specific license type we'd use, may also be worth an email to the site admin explaining geoBoundaries and asking what license type to use

lydiatroup commented 2 years ago

@SidonieH we're going with "Federal Office of Topography swisstopo License" it'll fail for a while but eventually pass when he updates the bot

maxmalynowsky commented 2 years ago

I'm not sure if further work was done on this, but I implemented the May 2022 update got ADM 0-3 from swisstopo and addressed the missing polygons in ADM2 by falling back to ADM1 boundaries as a gap filler. This is the approach I saw others implement here: https://demos.mapbox.com/boundaries-explorer/?country=CH&layer=adm2&worldview=US

Also, I saw that the license for this dataset is CC-BY: https://opendata.swiss/en/dataset/swissboundaries3d

Link for PR: https://github.com/wmgeolab/geoBoundaries/pull/2364