search

wmira / react-icons-kit

React Svg Icons
https://react-icons-kit.vercel.app/
MIT License
370 stars 45 forks source link

Version 1.1.6 on npm breaks styling #29

Closed AntonFriberg closed 6 years ago

AntonFriberg commented 6 years ago

The 1.1.6 version that is deployed on npm 8 days ago changes the behavior of the inline styling. I am also unable to override this styling with my own style prop. The change greatly affects the look of the icon since the div container takes up much more space.

With 1.1.6 I get the following styling

div {
display: flex;
justify-content: center;
align-items: center;
}

Previously i got this.

div {
display: inline-flex;
justify-content: center;
align-items: center;
}

Any reason why the 1.1.6 changes are not on github yet? Without the breaking changes published I am unable to provide pull request.

wmira commented 6 years ago

Apologies, will revert this change. Please use 1.1.5 for now.

On Wed, Jul 25, 2018, 7:52 PM Anton Friberg notifications@github.com wrote:

The 1.1.6 version that is deployed on npm 8 days ago changes the behavior of the inline styling. I am also unable to override this styling with my own style prop. The change greatly affects the look of the icon since the div container takes up much more space.

With 1.1.6 I get the following styling

div {display: flex;justify-content: center;align-items: center; }

Previously i got this.

div {display: inline-flex;justify-content: center;align-items: center; }

Any reason why the 1.1.6 changes are not on github yet? Without the breaking changes published I am unable to provide pull request.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wmira/react-icons-kit/issues/29, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcmEAx-ECUPqT2pwptatfelIb1lmu7Lks5uKFvpgaJpZM4Vf8S8 .

wmira commented 6 years ago

@AntonFriberg i reverted that to the old where I let user override it again. I was fixing issue where some style get reset because the style props from user are applied last. Will get this properly fixed in another release. I published it @1.1.7

AntonFriberg commented 6 years ago

Thanks for the quick fix! It would help debugging efforts if you keep the github changes up to date with the changes submitted to npm.

AntonFriberg commented 6 years ago

Tested and working @1.1.7 closing the issue.