search

wmira / react-icons-kit

React Svg Icons
https://react-icons-kit.vercel.app/
MIT License
369 stars 44 forks source link

Remove style attributes in favor of CSS class #41

Open blakestone95 opened 5 years ago

blakestone95 commented 5 years ago

A team member switched us to this library from material-design-icons, but it messed up a bunch of our styling. After perusing the source code, I have a suggestion: remove the style attributes used in Icon and SvgIcon and instead use a CSS class (perhaps className="react-icons-kit") with some CSS to apply the inline-block and vertical-align rules. My reasoning is that this will make it easier to style the icons and override your defaults without having to add a className and style to every Icon component.

wmira commented 5 years ago

@blakestone95 apologies for the very late reply. I will update this such that users should be able to compose a specific container of their liking -- e.g. with their own default className. styles will also be not added by default. Will update once it gets released