search

wmira / react-icons-kit

React Svg Icons
https://react-icons-kit.vercel.app/
MIT License
370 stars 45 forks source link

Adding <span/> and <i/> to tag options #42

Closed ghost closed 5 years ago

ghost commented 5 years ago

@wmira,

Your react-icons-kit is very helpful! Thank you for making if available. I only wish we could use a different tag (other than <div/>) for the element. So, I forked your master branch and added <span/> and <i/> as alternatives, letting the user decide which works best. I also made <i/> the default.

wmira commented 5 years ago

@nbcnc thanks for pr. Will publish tomorrow.