search

wmira / react-icons-kit

React Svg Icons
https://react-icons-kit.vercel.app/
MIT License
370 stars 44 forks source link

Allow IconProp type definition to allow all HTML attributes. #58

Closed vahissan closed 3 years ago

vahissan commented 3 years ago

I was getting TypeScript errors when I tried to set regular HTML attributes like tabIndex and onKeyDown props to the Icon component. Since those additional props are working fine functionally, I think it's better to add this to the type declaration.