search

wmlele / devise-otp

Two Factors authentication for Devise using Time Based OTP/rfc6238 tokens.
MIT License
201 stars 38 forks source link

Implement own SMS messages? #3

Closed ogminor closed 10 years ago

ogminor commented 10 years ago

SMS are easy to send to most people, since you can simply email their number@provider. Do you see this as within the scope of this project? I was considering forking your project and contributing to it as it seems to fit my needs more than other 2Factor devise plugins.

Should I issue pull requests on these changes? I also use mongo so I will be added mongo generators.

wmlele commented 10 years ago

Can you please expand a little what is your requirement about SMS: how would the sign-in process work?

ogminor commented 10 years ago

I was considering adding an alternative 2-factor to google authenticate.

Basically the user would register their phone number and then receive text messages with OTP's that expire in x amount of time. The user would check their phone, type in the OTP and gain access to their account. In my system I would do this after the user logins in with their username and password as both would be required.

If this is out of the scope of your project I understand but I figured I would propose the feature.

wmlele commented 10 years ago

Well, it's definitely a different authentication scheme, although you can use HOTP as a generator for it. While implementing the actual framework for sending SMS is probably out of scope, I can make it easier to hook it into the current scheme.

ogminor commented 10 years ago

Okay thank you for the feedback, if I implement this, I will do so as something separately to this project.