search

wmluke / dokku-domains-plugin

Dokku plugin to create nginx vhost with multiple domains
MIT License
176 stars 21 forks source link

Persistence #1

Closed jbrooksuk closed 10 years ago

jbrooksuk commented 10 years ago

Every time I push my app, I need to re-run the domains:set command. Is this normal?

wmluke commented 10 years ago

Hi @jbrooksuk,

Sorry for the delay...been super busy. I'll look into this weekend. In the meantime if you find time to dig-in, shoot me a PR.

Thanks, Luke

jbrooksuk commented 10 years ago

Sure thing @wmluke, should it be persisting the domains?

I notice this after a push or issuing a restart/build command.

wmluke commented 10 years ago

Hi @jbrooksuk,

Sorry for the extended delay. It should have persisted domains and does now.

Thanks for the filing the issue.

jbrooksuk commented 10 years ago

No worries, I'd had a go but never imagined it would be done the way you've fixed it.

It works brilliantly!