search

wmluke / dokku-domains-plugin

Dokku plugin to create nginx vhost with multiple domains
MIT License
176 stars 21 forks source link

Fails with HTTPS #4

Closed darkpixel closed 10 years ago

darkpixel commented 10 years ago

Dokku will look for GITROOT/ssl/server.{crt,key} and generate nginx configs for HTTPS and forcibly-redirect HTTP to HTTPS.

The plugin appears to only generate configs for HTTP.

wmluke commented 10 years ago

Hi @darkpixel,

At this time this plugin does not support SSL virtual hosts in master (v0.1.1).

Typically, SSL certificates only work for a single domain (foo.com) and its subdomains (www.foo.com, api.foo.com), but this plugin allows you to create virtual hosts for multiple domains (foo.com, bar.com). I've been playing around with possible CLI API's to generate SSL virtual hosts in the develop branch.

You can preview the commands in my develop unit tests.

I'd welcome any feedback on how you'd like to map hostnames and certificates together.

In the meantime, I've opened #5 to track this issue for the next release.

Thanks for the feedback.

darkpixel commented 10 years ago

Yup. I use dokku in development and production. appname.dev.example.tld works fine for staging and testing, my production apps go to appname.prod.example.tld and I was wanting to use the domain plugin so I could point the actual domain names at the apps--including SSL. :)