feat: remove `docker-compose` as a dependency

wmnnd / nginx-certbot

Boilerplate configuration for nginx and certbot with docker-compose

MIT License

3.16k stars 1.17k forks source link

feat: remove `docker-compose` as a dependency #50

Closed okeyokoro closed 4 years ago

okeyokoro commented 5 years ago

I had trouble deploying this setup on a GCP VM running their "Container-Optimized OS"

See reasons here: https://cloud.google.com/community/tutorials/docker-compose-on-container-optimized-os

Refactoring this script allowed me to get up & running.

I think if you accepted these changes, You would make the software more accessible

wmnnd commented 5 years ago

Hey @okeyokoro, thank you for your merge request! I wonder if this might have any weird side-effects on machines that do have docker-compose, though …

okeyokoro commented 5 years ago

@wmnnd thank you, for making this awesome repo!

any weird side-effects on machines that do have docker-compose,

^ this is a totally valid point, that I didn't pay much consideration tbh

in theory, we should be good (since it's just a container). but I can't say i'm 100% certain that there won't be any surprises

If you'd like;

a read could be added; prompting the user to choose either one of the methods

^ after the prompt we would simply define dc to either use:

docker-compose "$@" or
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v "$PWD:$PWD" -w="$PWD" docker/compose:1.24.0 "$@"

wmnnd commented 5 years ago

Do you think you could modify this for the 2.x branch so that it uses docker-compose when installed and otherwise asks the user whether they want to continue using compose in a container? Maybe allow skipping the question with a parameter like --docker-compose-in-docker.

okeyokoro commented 5 years ago

sounds great, I'll get to work on that 🙂

okeyokoro commented 4 years ago

closing this since i've got #57 up