search

wmo-im / BUFR4

BUFR edition 4
MIT License
27 stars 9 forks source link

Validate Machine Readable Codes - v36 Release Candidate #61

Closed amilan17 closed 3 years ago

amilan17 commented 3 years ago

Release Candidate

https://github.com/wmo-im/BUFR4/releases/tag/v36RC

Summary and purpose

To ensure that the v36RC machine-readable codes are valid and ready for testing during the comment period. 

Action proposed

  1. [x] Update script to NOT output the "\ " tag in the XML (see Issue #23)
  2. [x] Identify key individuals to test
  3. [x] Confirm file validation

Discussions

Machine-Readable Files

amilan17 commented 3 years ago

removed \ tags -- ready to test.

amilan17 commented 3 years ago

@SimonElliottEUM @erget tested and found no problems.

SibylleK commented 3 years ago

I have checked the XML-files They are OK, except of one or more space characters at the end of some entries. But these spaces could also be found in the csv-files. A space at the end of the header of BUFRCREX_CodeFlag_en_01.csv leads to a ""-tag in BUFRCREX_CodeFlag_en.xml, as a space in the header is replaces by "-" in csv2xml.py. To avoid unneeded spaces in the converted XML-files csv2xml.py could be supplemented by "field = field.rstrip()" and "header[i] = header[i].rstrip()".

amilan17 commented 3 years ago

validated (extra space >> - is removed)