wmo-im / GRIB2

GRIB2
MIT License
21 stars 9 forks source link

Normalize template notes questions #118

Closed amilan17 closed 2 years ago

amilan17 commented 2 years ago

See questions in comments below.

amilan17 commented 2 years ago

Question A - See Issue #131 

Do these two notes mean the same thing? If so, which one is better? 

28Grid length is in units of 10-3 m at the latitude specified by LaD.
29Grid lengths are in units of 10–3 m, at the latitude specified by the standard parallel.

found in:

and 

amilan17 commented 2 years ago

see issue # #138

Do we need to keep these notes associated with the templates?  

21For most templates, details of the packing process are described in Regulation 92.9.4.

Found in 

158

For most templates, details of the packing process are described in regulation 92.9.4. 

This template is only valid for the Consultative Committee for Space Data Systems Recommendation for Space Data System Standards, Lossless Data Compression, CCSDS 121.0-B-2, Blue Book, May 2012.

Found in, should probably be two notes, if we keep it. 

amilan17 commented 2 years ago

see issue #139

these two notes look the same. Which note is better?

31Group lengths have no meaning for row by row packing, where groups are coordinate lines (so the grid description section and possibly the bit-map section are enough); for consistency, associated field width and reference should then be encoded as 0.
32Group lengths have no meaning for row by row packing; for consistency, associated field width should then been coded as 0. So no specific test for row by row case is mandatory at decoding software level to handle encoding/decoding of group descriptors.

Found in:

amilan17 commented 2 years ago

see issue #140 

These notes are almost identical. Is it important to preserve the the reference to specific octets?

95The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 46, 58, 70, ...). For all but the innermost (last) time range, the next inner range is then processed using these references and forecast times as the initial reference and forecast times.
96The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 48, 60, 72, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
97The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 50, 62, 74, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
98The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 51, 62, 73, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
99The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 51, 63, 75, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
100The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 53, 65, 77, …). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
101The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 54, 66, 78, …). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
102The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 56, 68, 80, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
103The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 57, 69, 81, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
104The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 61, 72, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
105The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 62, 74, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
106The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 63, 65, 77, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
107The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 63, 75, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
108The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 78, 90, 112, ...). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
109The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment (one of octets 82, 94, 106,....). For all but the innermost (last) time range, the next inner range is then processed using these reference and forecast times as the initial reference and forecast times.
110The reference and forecast times are successively set to their initial values plus or minus the increment, as defined by the type of time increment. For all but the innermost (last) time range, the next inner range is then processed using these references and forecast times as the initial reference and forecast times.
amilan17 commented 2 years ago

See issue #141

134This template was not validated at the time of publication and should be used with caution. Please report any use to the WMO Secretariat to assist for validation.
130This template is experimental, was not validated at the time of publication and should be used only for bilateral previously agreed tests.
131This template is experimental, was not validated at the time of publication and should be used only for bilateral previously agreed tests. (Octets 35-50 are very similar to octets 43-58 of product definition template 4.8, but the meaning of some fields differs slightly.)
amilan17 commented 2 years ago

See issue #142 

140This represents the length of time over which the statistical processing was applied. The local time defined in section 1 represents the end of this processing. For instance, a value of 24h corresponds to a statistical processing between the previous day at local time and this day at local time.

found in 

143This also represents the length of time range of the statistical processed fields. For instance, to create a 24h accumulation (encoded in octet 29-32), we could use several 3h accumulations, or 6h accumulation, a mixture of the two, etc.
145This also represents the length of time range of the statistical processed fields. For instance, to create a 24h accumulation (encoded in octet 32-35), we could use several 3h accumulations, or 6h accumulation, a mixture of the two, etc.
147This also represents the length of time range of the statistical processed fields. For instance, to create a 24h accumulation (encoded in octet 34-37), we could use several 3h accumulations, or 6h accumulation, a mixture of the two, etc.
149This also represents the length of time range of the statistical processed fields. For instance, to create a 24h accumulation (encoded in octet 37-40), we could use several 3h accumulations, or 6h accumulation, a mixture of the two, etc.
amilan17 commented 2 years ago

see issue #143

150The reference time in octets 44-50 and the forecast time together define the beginning of the overall time interval.
151The reference time in octets 41-47 and the forecast time together define the beginning of the overall time interval.
152The reference time in octets 39-45 and the forecast time together define the beginning of the overall time interval.
153The reference time in octets 36-42 and the forecast time together define the beginning of the overall time interval.
154The reference time in octets 37-43 and the forecast time together define the beginning of the overall time interval.
155The reference time in octets 34-40 and the forecast time together define the beginning of the overall time interval.
156The reference time in octets 32-38 and the forecast time together define the beginning of the overall time interval.
sebvi commented 2 years ago

@amilan17 I haven't found the time to look at this but I could have a look before the meetings in November

amilan17 commented 2 years ago

@sebvi will you have time to look at this soon?

sebvi commented 2 years ago

I will try to have a look at it this evening

sebvi commented 2 years ago

For the comment that are all similar but differing by only the octet numbers mentioned, I would suggest to add in the templates a reference in the description of the relevant octets and use that reference that instead of the octets in the notes.

I will look at the other cases but it is not easy because I need to find out to which templates they correspond and look at those templates.

amilan17 commented 2 years ago

For the comment that are all similar but differing by only the octet numbers mentioned, I would suggest to add in the templates a reference in the description of the relevant octets and use that reference that instead of the octets in the notes

Assuming this is related to question D -- it sounds too complicated at the moment to re-design.

amilan17 commented 2 years ago

@sebvi -- I hope I provided enough context for the questions in this issue. Questions D, F and G are about specific octets...

amilan17 commented 2 years ago

new issues created to address specific issues related to notes.