search

wmo-im / GRIB2

GRIB2
MIT License
22 stars 9 forks source link

Wrong reserved range for table 4.2 and "Product discipline 0 - Meteorological products, parameter category 1: moisture" #129

Closed rouault closed 2 years ago

rouault commented 2 years ago

Branch

https://github.com/wmo-im/GRIB2/tree/issue129

Summary and purpose

In table https://raw.githubusercontent.com/wmo-im/GRIB2/master/GRIB2_CodeFlag_4_2_CodeTable_en.csv, there are the following records:

Parameter number by product discipline and parameter category,"Product discipline 0 - Meteorological products, parameter category 1: moisture",149,,Cloud water mixing ratio,,kg kg-1,Operational
Parameter number by product discipline and parameter category,"Product discipline 0 - Meteorological products, parameter category 1: moisture",149-191,,Reserved,,,Operational

The range 149-191 conflicts with the previous record

Action proposed

Change range 149-191 to 150-191

amilan17 commented 2 years ago

@jitsukoh This was a typo. Please validate the edit https://github.com/wmo-im/GRIB2/compare/FT22-1...issue129

amilan17 commented 2 years ago

@rouault Thanks for letting us know.

jitsukoh commented 2 years ago

@amilan17 I confirm that the CSV file was corrected and the issue is moved to the validated status.

jitsukoh commented 2 years ago

@amilan17 I found a "different" typo in the same table in the PDF version (I am looking at 306_I2_2019_updated 2021_en_july.pdf). "Reserved" figures should be 150-191.

GRIB4 2-0-1

At this moment, I moved this back to in validation.

amilan17 commented 2 years ago

@jitsukoh if I understand correctly, the error in the CSV is the same as the error in the PDF. The CSV is now correct and the PDF will be corrected at the same time as the other amendments.

jitsukoh commented 2 years ago

@amilan17 thanks. The CSV said "149-191" but the PDF said "147-191" but the wrong part is the same. Moved to validated again.