wmo-im / GRIB2

GRIB2
MIT License
22 stars 9 forks source link

Code/Flag table 3.1: GRIB Mercator grid types #33

Closed shahramn closed 2 years ago

shahramn commented 4 years ago

Branch

https://github.com/wmo-im/GRIB2/tree/issue33

Discussion

I noticed that the Code/Flag table 3.1 has ONE entry for Mercator

Code table 3.1 – Grid definition template number
10 Mercator
11-12 Reserved

But the Templates document has TWO entries:

Grid definition template 3.10 – Mercator
Grid definition template 3.12 – transverse Mercator

Why is there a template for 3.12 but it's not in the table?

Proposal

Add Transverse Mercator to Code Table 3.1

Grid definition template number 12 Transverse Mercator
sebvi commented 3 years ago

We have indeed a Grid Definition Template 3.12 that is not referenced in Code table 3.1, we need to add it. Can we create a branch @amilan17 ? Thanks

amilan17 commented 3 years ago

https://github.com/wmo-im/GRIB2/tree/issue-33

amilan17 commented 3 years ago

@amilan17 update branch

chenxiaoxia2019 commented 3 years ago

@amilan17 The branch has been updated. One minor question for "transverse", shall we use "transverse Mercator" or "Transverse Mercator"? Currently, template 3.12 is using "transverse Mercator". But, I notice that in Code table 3.1, all the first words are capitalized.

chenxiaoxia2019 commented 3 years ago

@amilan17 As agreed, we use "Transverse Mercator" in both the Code table 3.1 and the template 3.12. The branch has been updated accordingly.

@amilan17 The branch has been updated. One minor question for "transverse", shall we use "transverse Mercator" or "Transverse Mercator"? Currently, template 3.12 is using "transverse Mercator". But, I notice that in Code table 3.1, all the first words are capitalized.

chenxiaoxia2019 commented 3 years ago

@amilan17 @shahramn @jitsukoh The branch has been updated.

jitsukoh commented 3 years ago

@amilan17 @shahramn @chenxiaoxia2019 I confirm that this proposal is finalized and the branch is updated, and move this issue to "Validated" status.