search

wmo-im / GRIB2

GRIB2
MIT License
22 stars 9 forks source link

Data representation template 5.42 title incorrect #64

Closed shahramn closed 3 years ago

shahramn commented 3 years ago

Regarding the Data representation template 5.42: "Grid point and spectral data - CCSDS recommended lossless compression"

The title of this scheme mentions "spectral data", which is confusing me as it does not have the right keys for representing spectral packing. Isn't CCSDS just like JPEG and PNG? if so then it would only be for GRID-POINT data and not spectral.

Its Note (1) says:

"The intent of this template is to scale the grid point data to obtain the desired precision, if appropriate, and then subtract the reference value from the scaled field, as is done using data representation template 5.0..."

So it affirms my suspicions: It is for GRID-POINT data. Later the note mentions data representation template 5.0 which is again for grid-point data (Grid point data-simple packing)

sebvi commented 3 years ago

My understanding is that this can be treated as an editorial change.

efucile commented 3 years ago

I agree that this is an editorial change.

sebvi commented 3 years ago

@wmo-im/tt-tdcf should we include this in FT-2021-1 ?

tomkralidis commented 3 years ago

+1 from me.

jitsukoh commented 3 years ago

@sebvi @tomkralidis thank you very much for the reminder. @amilan17 I would suggest that we include this in FT2021-1 as an editorial change.

amilan17 commented 3 years ago

@shahramn @sebvi 

I removed 'and spectral data' from the title. Can you confirm that this in alignment with the decision? 

a711c82

shahramn commented 3 years ago

It should start with "Grid point data - ". You have omitted the word "data". So for example the first line should read: Grid point data - CCSDS recommended lossless compression,12-15,Reference value (R) (IEEE 32-bit floating-point value),,Operational etc...

sebvi commented 3 years ago

@amilan17 : This issue has the FT2021-1 milestone but is not tagged with the branch FT-2021. Will it be part of the next release?

amilan17 commented 3 years ago

It is in this FT2021-1 release. :-)

shahramn commented 3 years ago

In the latest draft version (release candidate 27RC): The file GRIB2_Template_5_42_DataRepresentationTemplate_en.csv has been corrected but I still see instances of the old title:

% grep -r 'spec.*CCSDS' GRIB2-27RC
GRIB2-27RC/GRIB2_CodeFlag_5_0_CodeTable_en.csv:Data representation template number,,42,,Grid point and spectral data - CCSDS recommended lossless compression,,,Operational
GRIB2-27RC/GRIB2_Template_7_42_DataTemplate_en.csv:Grid point and spectral data - CCSDS recommended lossless compression,6-nn,CCSDS recommended standard for lossless data compression code stream,,Operational
GRIB2-27RC/csv/CodeFlag.txt:Code table 5.0 - Data representation template number,,42,,Grid point and spectral data - CCSDS recommended lossless compression,,,Operational
GRIB2-27RC/csv/Template.txt:Data template 7.42 - Grid point and spectral data - CCSDS recommended lossless compression,6-nn,CCSDS recommended standard for lossless data compression code stream,,Operational
GRIB2-27RC/csv/CodeFlag.txt.tsv:Code table 5.0 - Data representation template number            42              Grid point and spectral data - CCSDS recommended lossless compression                     Operational
GRIB2-27RC/csv/27.draft/5.0.table:42 42 Grid point and spectral data - CCSDS recommended lossless compression 
GRIB2-27RC/xml/CodeFlag.xml:            <MeaningParameterDescription_en>Grid point and spectral data - CCSDS recommended lossless compression</MeaningParameterDescription_en>
GRIB2-27RC/xml/Template.xml:            <Title_en>Data template 7.42 - Grid point and spectral data - CCSDS recommended lossless compression</Title_en>
efucile commented 3 years ago

@shahramn thanks we'll fix this in the final release

amilan17 commented 3 years ago

@sebvi  - I updated the GRIB2_Template_7_42_DataTemplate_en.csv and GRIB2_CodeFlag_5_0_CodeTable_en.csv in branch Issue64 and requested you to review the pull request.