Closed sebvi closed 2 years ago
@sebvi -- we have a new approach for managing notes for GRIB templates. I will present it at the next meeting, however, I can speak with you before then if needed.
@amilan17 : saw it, it looks good. I see how you implemented it, should I created a noteID in the new table and then use that noteID in the relevant columnb of my templates?
@sebvi , Yes exactly, but first review the existing notes and reference ones that are already established as applicable. For example, note 33 (Hours greater than 65534 will be coded as 65534.), is a common one and is already referenced 63 times in the templates.
I have updated the proposal to move the local time method closer to the other keys it belongs to in proposed templates 4.95 to 4.98
I will provide sample GRIB either tomorrow or on Monday
Having problem to upload as usual :S
trying again templates.zip
I have updated the branch.
@amilan17 During the process I noted that template 4.88 refers to table 2.248 instead of 4.248. Should I open a separate issue for an editorial change?
@sebvi -- yes, please open a separate issue and tag me. If we do this quickly, we can include in FT2021-2.
@amilan17 I have already done so, it is issue #107
@sebvi in the branch, I found misspelling in the name of PDT 4.95.
In GRIB2_CodeFlag_4_0_CodeTable_en.csv
Product definition template number,,95,,"Average, accumulation extreme values or other statiscally processed value at a horizontal level or in a horizontal layer at a specified local time",,,Operational
should be
Product definition template number,,95,,"Average, accumulation, extreme values or other statistically processed value at a horizontal level or in a horizontal layer at a specified local time",,,Operational
(added comma after accumulation and corrected the spelling of statistically)
And then all the Title_en in GRIB2_Template_4_95_ProductDefinitionTemplate_en.csv need to be corrected accordingly.
@jitsukoh @sebvi
I updated the branch
@amilan17 thank you. I think the comma after "accumulation" in GRIB2_CodeFlag_4_0_CodeTable_en.csv is still missing.
@sebvi In the following templates, there are references to notes in the notes_en column, but no associated number in the noteIDs column
@jitsukoh - thanks, I think I added all the necessary commas now.
@amilan17 @jitsukoh I have updated the branch with whatever was missing, please have a look
@sebvi -- Thank you very much for updating the notes. I merged your branch into FT21-2, but we are having difficulty verifying the content, because now the issue summary (at the top of this issue) does not match the content. Can you please update the issue summary? @chenxiaoxia2019 is double/triple checking everything and we need to get this done this week.
Templates 4.93 and 4.94 in issue summary are inconsistent with content in FT21-2 branch.
@amilan17 and @chenxiaoxia2019 : if you could point out what is not matching, that would help
@sebvi Hi, Sebastien, it is about the added notes in Templates 4.93, 4.94. In the "Detailed Proposal", in these templates, there are no notes. Yet in the GitHub branch, there are notes.
Branch
https://github.com/wmo-im/GRIB2/tree/issue84
Summary and purpose
ECMWF is proposing a new set of templates to extend existing templates for use with local time
Proposer
Sebastien Villaume (ECMWF)
Action proposed
The team is kindly asked to review and approve the contents for inclusion within the next update to the WMO Manual on Codes.
Discussions
Following the recent validation of the new local time template (4.88), issue https://github.com/wmo-im/GRIB2/issues/6 , we would like to extend the concept to be used in EPS and in postprocessing models. WE also extend the local time to be be used with statistically processed parameters.
LocalTime.pptx
Detailed proposal
Template 4.92 Individual ensemble forecast, control and perturbed at a horizontal level or in a horizontal layer at a local Time
Template 4.93 Post-processing analysis or forecast at a horizontal level or in a horizontal layer at a local Time
Template 4.94 Post-processing individual ensemble forecast, control and perturbed, at a horizontal level or in a horizontal layer at a local Time
TEMPLATE 4.95 Average, accumulation, extreme values or other statistically processed values at a horizontal level or in a horizontal layer at a local Time
Notes: (1) This represents the length of time over which the statistical processing was applied. The local time defined in section 1 represents the end of this processing. For instance, a value of 24h corresponds to a statistical processing between the previous day at local time and this day at local time. (2) This represents the number of statistically processed fields (or stripes) used to create the composite local time field. For instance a value of 8 means that 8 statistically processed fields have been used in the processing, each of them representing a section of 45 degrees of longitude (360/8) centered around the UTC time corresponding to the local time. (3) This is the number of forecasts and time steps used to create the statistically processed fields. These implicitly have the same statistical process as defined in octet 27. If a forecast has 2 time increments (3 hourly day 1 to 5 then 6 hourly), it should be encoded as 2 forecasts with the same reference time, using the appropriate starting forecast time and time increments. (4) This also represents the length of time range of the statistical processed fields. For instance, to create a 24h accumulation (encoded in octet 29-32), we could use several 3h accumulations, or 6h accumulation, a mixture of the two, etc.
TEMPLATE 4.96 Average, accumulation, extreme values or other statistically processed values of an individual ensemble forecast, control and perturbed at a horizontal level or in a horizontal layer at a local Time
Notes: (1) This represents the length of time over which the statistical processing was applied. The local time defined in section 1 represents the end of this processing. For instance, a value of 24h corresponds to a statistical processing between the previous day at local time and this day at local time. (2) This represents the number of statistically processed fields (or stripes) used to create the composite local time field. For instance a value of 8 means that 8 statistically processed fields have been used in the processing, each of them representing a section of 45 degrees of longitude (360/8) centered around the UTC time corresponding to the local time. (3) This is the number of forecasts and time steps used to create the statistically processed fields. These implicitly have the same statistical process as defined in octet 30. If a forecast has 2 time increments (3 hourly day 1 to 5 then 6 hourly), it should be encoded as 2 forecasts with the same reference time, using the appropriate starting forecast time and time increments. (4) This also represents the length of time range of the statistical processed fields. For instance, to create a 24h accumulation (encoded in octet 32-35), we could use several 3h accumulations, or 6h accumulation, a mixture of the two, etc.
TEMPLATE 4.97 Average, accumulation, extreme values or other statistically processed values of a post-processing analysis or forecast at a horizontal level or in a horizontal layer at a local Time
Notes: (1) This represents the length of time over which the statistical processing was applied. The local time defined in section 1 represents the end of this processing. For instance, a value of 24h corresponds to a statistical processing between the previous day at local time and this day at local time. (2) This represents the number of statistically processed fields (or stripes) used to create the composite local time field. For instance a value of 8 means that 8 statistically processed fields have been used in the processing, each of them representing a section of 45 degrees of longitude (360/8) centered around the UTC time corresponding to the local time. (3) This is the number of forecasts and time steps used to create the statistically processed fields. These implicitly have the same statistical process as defined in octet 32. If a forecast has 2 time increments (3 hourly day 1 to 5 then 6 hourly), it should be encoded as 2 forecasts with the same reference time, using the appropriate starting forecast time and time increments. (4) This also represents the length of time range of the statistical processed fields. For instance, to create a 24h accumulation (encoded in octet 34-37), we could use several 3h accumulations, or 6h accumulation, a mixture of the two, etc.
TEMPLATE 4.98 Average, accumulation, extreme values or other statistically processed values of a post-processing individual ensemble forecast, control and perturbed, at a horizontal level or in a horizontal layer at a local Time
Notes: (1) This represents the length of time over which the statistical processing was applied. The local time defined in section 1 represents the end of this processing. For instance, a value of 24h corresponds to a statistical processing between the previous day at local time and this day at local time. (2) This represents the number of statistically processed fields (or stripes) used to create the composite local time field. For instance a value of 8 means that 8 statistically processed fields have been used in the processing, each of them representing a section of 45 degrees of longitude (360/8) centered around the UTC time corresponding to the local time. (3) This is the number of forecasts and time steps used to create the statistically processed fields. These implicitly have the same statistical process as defined in octet 35. If a forecast has 2 time increments (3 hourly day 1 to 5 then 6 hourly), it should be encoded as 2 forecasts with the same reference time, using the appropriate starting forecast time and time increments. (4) This also represents the length of time range of the statistical processed fields. For instance, to create a 24h accumulation (encoded in octet 37-40), we could use several 3h accumulations, or 6h accumulation, a mixture of the two, etc.