wmo-im / GRIB2

GRIB2
MIT License
23 stars 9 forks source link

Code table 4.2: new hydrological parameters #86

Closed sebvi closed 2 years ago

sebvi commented 3 years ago

Branch

https://github.com/wmo-im/GRIB2/tree/issue86

Summary and purpose

ECMWF is requesting new hydrological parameters for the EFAS, GLOFAS and ULYSSES projects.

Action proposed

The team is kindly asked to review and approve the contents for inclusion within the next update to the WMO Manual on Codes.

Discussions

ECMWF is operating several services for the Copernicus program in the domain of flood forecasting (EFAS/GLOFAS) and hydrological seasonal predictions (ULYSSES). For these projects new (or correct) parameters are needed:

Detailed proposal

add in code table 4.2 Discipline Category Code Meaning Units
2 0 41 Snow melt rate kg m-2 s-1
2 0 42 Water runoff and drainage rate kg m-2 s-1

add notes

SimonElliottEUM commented 3 years ago

keypad

SimonElliottEUM commented 3 years ago

As you can see, my key pad at home is the other way around

lemkhenter commented 3 years ago

Drainage direction: this parameter is provided by a hydraulic terrain model. This type of model is interested in the neighboring grid points to which the water drop can orient itself. It is therefore a 3 * 3 grid around the point in question. So I agree with proposal.

SimonElliottEUM commented 3 years ago

Noting @lemkhenter 's comment, it looks like a code table defining the "direction" of the neighbouring grid will be best. Not degrees.

sebvi commented 3 years ago

updated the proposal to take into acocund yesterday's comments.

lemkhenter commented 3 years ago

In my opinion, this proposal requires further study for several reasons: 1- the direction parameter, like the wind direction, requires the designation of an origin and a direction of evolution. 2- In the field of hydrology, the terrain models do not always have rectangular / square meshes. some models have a triangular mesh for example. For these reasons and others on which specialists in the field can clarify, I propose to submit the proposal to a hydrology group for more detail and precision.

sebvi commented 3 years ago

Thank you @lemkhenter for your comments.

1- I think all directions we have (wind, waves, ocean currents, etc.) all have an origin at the centre of the grid box. Do you have an example where it is not the case? In the case of cardinal directions and not degrees, it seems to me that the "North" will be the North regardless of the origin chosen and the direction of evolution is implicitly "towards North" (because away from North would be then towards South). Would it help if we rename the parameter "Drainage Cardinal Direction"? 2- If a model has different requirements, for instance triangle mesh as you suggests with only 4 directions (3 sides of the triangle + no direction), there is nothing that prevents adding other entries in the new table. For instance one could imagine to add "south south east", "east south east", "south south west", "west south west", etc.

sebvi commented 3 years ago

Note that if we rename the parameter Drainage cardinal direction, we restrict future use cases, for instance someone using "up" "Down", "left", "right" (although I would not be in favor of this sort o use case!!)

SimonElliottEUM commented 3 years ago

@lemkhenter suggests to "submit the proposal to a hydrology group for more detail and precision". This seems like a wise move to me. We are an expert team on data representation - not hydrology. In a similar way we take satellite related topics to the CGMS Task Group on Satellite Data and Codes

sebvi commented 3 years ago

yes sure we can definitely do that. I don't have a contact point for an hydrology group (other than our own in-house group) so I am happy to take any suggestion.

amilan17 commented 3 years ago

per meeting discussion: Upstream area will be added, A code table will be proposed for Drainage direction,

jitsukoh commented 3 years ago

@amilan17 @efucile I should have asked you earlier, but we need to consult this proposal to a relevant group of hydrological experts, which I don't know. Can you suggest which group we should consult and how? I understand there is a SC member from CHy: Mr Juan Bianchi, and there is also ET-HYDMON under INFCOM...

sebvi commented 3 years ago

I am happy to park for now parameters "Upstream area", "Drainage direction" and "Return period" until we receive a feedback from Hydrological teams. But I would really like to go forward with "Snowmelt rate" and "Water runoff and Drainage rate".

amilan17 commented 3 years ago

per discussion at meeting: split move terms that need more consultation to new issue and update original comment with values that will go through FT2021-2. Also, provide link to new issue.

sebvi commented 3 years ago

removed the withdrawn parameters. I will move them to a new issue. Is there a way to move the valuable comments to the new issue?

sebvi commented 3 years ago

branch updated

jitsukoh commented 3 years ago

@sebvi @amilan17 I confirm that this proposal is finalized and the branch is updated, and move this issue to "Validated" status.

amilan17 commented 3 years ago

@sebvi - Suggestion for notes, based on the proposal to deprecate terms. 

sebvi commented 3 years ago

@amilan17 I am happy with your suggestions.