wmo-im / GRIB2

GRIB2
MIT License
21 stars 9 forks source link

normalize notes for codeflags #98

Closed amilan17 closed 2 years ago

amilan17 commented 3 years ago

Branch

https://github.com/wmo-im/GRIB2/tree/codeFlagNotes

https://github.com/wmo-im/GRIB2/compare/dd7fa791680aab5ef6829671f61dffaf631d941a...codeFlagNotes

amilan17 commented 3 years ago

For Review/Validation

1. Code Table 3.2: 10 -- note was not previously associated (10) Earth model assumed WGS84 with corrected geomagnetic coordinates (latitude and longitude) defined by Gustafsson et al., 1992 note: WGS-84 is a geodetic system that uses IAG-GRS80 as a basis.

2. Code Table 4.5: notes were not associated 111 Eta level (see Note 1) (1) The Eta vertical coordinate system involves normalizing the pressure at some point on a specific level by the mean sea-level pressure at that point.

118 Hybrid height level (see Note 2) (2) Hybrid height level (Code figure 118) can be defined as: z(k) = A(k) + B(k) x orog (k = 1,...,NLevels; orog = orography; z(k) = height in metres at level k)

3. Code table 4.2: notes were not associated 2 Remotely sensed snow cover (see Note 1) 3 Elevation of snow-covered terrain (see Note 2) 4 Snow water equivalent per cent of normal (see Note 3) Notes: (1) Remotely sensed snow cover is expressed as a field of dimensionless, thematic values. The currently accepted values are for no-snow/no-cloud, 50, for clouds, 100, and for snow, 250 (see Code table 4.215). (2) A data field representing snow coverage by elevation portrays at which elevations there is a snow pack. The elevation values typically range from 0 to 90 in 100-metre increments. A value of 253 is used to represent a no-snow/no-cloud data point. A value of 254 is used to represent a data point at which snow elevation could not be estimated because of clouds obscuring the remote sensor (when using aircraft or satellite measurements). (3) Snow water equivalent per cent of normal is stored in per cent of normal units. For example, a value of 110 indicates 110 per cent of the normal snow water equivalent for a given depth of snow

amilan17 commented 3 years ago

compare changes to notes (new diff link)

https://github.com/wmo-im/GRIB2/compare/dd7fa791680aab5ef6829671f61dffaf631d941a...codeFlagNotes

view notes:

https://github.com/wmo-im/GRIB2/blob/codeFlagNotes/notes/codeTableNotes.csv

amilan17 commented 2 years ago

@sebvi will you please take a look at this soon?

sebvi commented 2 years ago

I will try to have a look this evening

sebvi commented 2 years ago

I is very hard to follow what has changed from the compare because the number of changes is huge as you added the new column for the Id of the notes everywhere :(

Could have been easier to check if adding all the new columns were contained in 1 single commit so that I can filter it out. Is it the case?

amilan17 commented 2 years ago

is very hard to follow what has changed from the compare because the number of changes is huge as you added the new column for the Id of the notes everywhere :(

Right. I will improve this issue for clarity, by adding references and a useful diff. Please don't waste your time. I should have something by end of today or the week.

amilan17 commented 2 years ago

amilan17 commented 2 years ago

Code Table 4.5

Added references to existing notes for 111, 118 and 119.  
(1) The Eta vertical coordinate system involves normalizing the pressure at some point on a specific level by the mean sea-level pressure at that point.

(2) Hybrid height level (Code figure 118) can be defined as:
z(k) = A(k) + B(k) x orog
(k = 1,...,NLevels; orog = orography; z(k) = height in metres at level k)

(3)     Hybrid pressure level, for which Code figure 119 shall be used instead of 105, can be defined as:

         p(k) = A(k) + B(k) x sp

         (k = 1,...,NLevels; sp = surface pressure; p(k) = pressure at level k)

amilan17 commented 2 years ago

4.2.1.0

add existing notes to parameters

(1) Remotely sensed snow cover is expressed as a field of dimensionless, thematic values. The currently accepted values are for no-snow/no-cloud, 50, for clouds, 100, and for snow, 250 (see Code table 4.215).
(2) A data field representing snow coverage by elevation portrays at which elevations there is a snow pack. The elevation values typically range from 0 to 90 in 100-metre increments. A value of 253 is used to represent a no-snow/no-cloud data point. A value of 254 is used to represent a data point at which snow elevation could not be estimated because of clouds obscuring the remote sensor (when using aircraft or satellite measurements).
(3) Snow water equivalent per cent of normal is stored in per cent of normal units. For example, a value of 110 indicates 110 per cent of the normal snow water equivalent for a given depth of snow

amilan17 commented 2 years ago

@sebvi -- I hope this provides more context -- apologies for the inconsistent presentations.

amilan17 commented 2 years ago

all new notes look appropriate.